[PATCH] D118864: [asan][test] Re-generate asan-check-memaccess-add.ll with update_llc_test_checks.py

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 2 16:56:41 PST 2022


MaskRay created this revision.
MaskRay added reviewers: kstoimenov, vitalybuka.
Herald added a subscriber: pengfei.
MaskRay requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

- LABEL is important to give a better diagnostic in case a check pattern fails
- Some NOT negative patterns are not effective. NEXT is useful to ensure a code sequence has the desired instructions and report a better diagnostic if something goes off.
- Since the ABI says the first parameter is in RDI. Replacing the pattern `[[REG16:.*]]` with `RDI` should not cause maintenance burden.

Since the test is pretty mechanical, just use update_llc_test_checks.py
to re-generate it. Most functions can use `nounwind` to avoid CFI
directives.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D118864

Files:
  llvm/test/CodeGen/X86/asan-check-memaccess-add.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118864.405497.patch
Type: text/x-patch
Size: 4281 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220203/cbb515f0/attachment.bin>


More information about the llvm-commits mailing list