[PATCH] D118854: [mte] fix compiler crash with musttail.

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 2 16:07:47 PST 2022


eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/test/CodeGen/AArch64/stack-tagging-musttail.ll:21
+  %6 = add nsw i32 %4, %5
+  %7 = musttail call noundef i32 @_Z3bari(i32 noundef %6)
+  ret i32 %7
----------------
It would be nice to check that settag goes before the musttail call. Also at least a brief comment about what is being tested for future maintainers ("regression test for a compiler crash ...")


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118854/new/

https://reviews.llvm.org/D118854



More information about the llvm-commits mailing list