[PATCH] D118853: [AMDGPU] Fix scheduler live-ins with debug inst at start of block

Vang Thao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 2 16:06:22 PST 2022


vangthao added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/GCNSchedStrategy.cpp:514
 
-    if (Regions[CurRegion].first == I) {
+    if (Regions[CurRegion].first == I || NonDbgMI == I) {
       LiveIns[CurRegion] = RPTracker.getLiveRegs();
----------------
arsenm wrote:
> could you just apply skipDebuInstructionsForward to MBB->begin instead of adding a second check
We would have to call skipDebugInstructionsForward on Regions[CurRegion].first per loop iteration or check if Regions[CurRegion].first is a debug instruction and set region live-ins before the loop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118853/new/

https://reviews.llvm.org/D118853



More information about the llvm-commits mailing list