[PATCH] D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration

Michael Spencer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 2 16:02:39 PST 2022


Bigcheese updated this revision to Diff 405482.
Bigcheese added a comment.

- Fixed documentation typo.
- Made missing '{' diagnostic more clear.
- Use `ModuleMapParser::skipUntil`.

Emitting an actual fixup is kind of difficult from `ModuleMapParser` because the way it handles tokens makes it hard to get the source location of the end of the line containing the requires feature list.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118311/new/

https://reviews.llvm.org/D118311

Files:
  clang/docs/Modules.rst
  clang/include/clang/Basic/DiagnosticLexKinds.td
  clang/include/clang/Basic/Module.h
  clang/lib/Basic/Module.cpp
  clang/lib/Lex/ModuleMap.cpp
  clang/test/Modules/requires-block-errors.m
  clang/test/Modules/requires-block.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118311.405482.patch
Type: text/x-patch
Size: 15542 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220203/53020635/attachment.bin>


More information about the llvm-commits mailing list