[PATCH] D118852: [NFC] pull retvec logic to MemoryTaggingSupport.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Utils/MemoryTaggingSupport.h:73
+
+void maybeAddToRetVec(Instruction &Inst,
+                      SmallVectorImpl<Instruction *> &RetVec);
----------------
fmayer wrote:
> eugenis wrote:
> > That's a very vague function name for the common utils header.
> > 
> > How about `getUntagLocationForFunctionExit` and return `Instruction*`?
> > 
> Good point. `getUntagLocationForFunctionExit` is a bit of a mouthfull though, what do you think about this?
I'd expect `untagLocationIfFunctionExit`  to actually emit the untagging code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118852/new/

https://reviews.llvm.org/D118852