[PATCH] D118633: [Symbolizer] Add Build ID flag to llvm-symbolizer.

Daniel Thornburgh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 2 14:45:42 PST 2022


mysterymath updated this revision to Diff 405455.
mysterymath marked 5 inline comments as done.
mysterymath added a comment.

- Refactored build ID lookup functionality into LLVMSymbolizer. This makes build IDs a first class means to specify modules. In particular, this produces consistent error behavior between paths and build IDs. This will also make it straightforward to extend the stdin syntax to support alternating build IDs and paths.

- Made --build-id and --obj mutually exclusive.

- Added tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118633/new/

https://reviews.llvm.org/D118633

Files:
  llvm/docs/CommandGuide/llvm-symbolizer.rst
  llvm/include/llvm/DebugInfo/Symbolize/Symbolize.h
  llvm/lib/DebugInfo/Symbolize/Symbolize.cpp
  llvm/test/tools/llvm-symbolizer/debuginfod-bad-build-id.test
  llvm/test/tools/llvm-symbolizer/debuginfod-build-id-and-obj.test
  llvm/test/tools/llvm-symbolizer/debuginfod-missing-build-id.test
  llvm/test/tools/llvm-symbolizer/debuginfod.test
  llvm/tools/llvm-symbolizer/Opts.td
  llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118633.405455.patch
Type: text/x-patch
Size: 20615 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220202/b07128bd/attachment.bin>


More information about the llvm-commits mailing list