[PATCH] D118786: [flang] Add lowering for integer constant

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 2 13:45:59 PST 2022


clementval marked 3 inline comments as done.
clementval added inline comments.


================
Comment at: flang/lib/Lower/ConvertType.cpp:499
+  }
+  llvm_unreachable("INTEGER type translation not implemented");
+}
----------------
kiranchandramohan wrote:
> Nit: Should this be "non-INTEGER type translation not implemented"?
It should only be called for Integer type but the kind might be off. I updated the message.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118786/new/

https://reviews.llvm.org/D118786



More information about the llvm-commits mailing list