[PATCH] D118545: [ARM] Fix 8-bit immediate overflow in the instruction of segmented stack prologue.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 2 13:37:36 PST 2022


efriedma added a comment.

Not sure about the discussion of MOVi32imm etc.  In ARM mode, the existing MOVi32imm can't be used for arbitrary constants without armv6t2.  For the general case, we emit a constant pool load.  Similarly, on Thumb, we just never bothered to implement tMOVi32imm.

Can we use emitThumbRegPlusImmediate/emitT2RegPlusImmediate/emitARMRegPlusImmediate here, instead of reimplementing it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118545/new/

https://reviews.llvm.org/D118545



More information about the llvm-commits mailing list