[PATCH] D118727: [MemoryBuiltins][FIX] Adjust index type size properly wrt. AS casts
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 2 13:35:34 PST 2022
jdoerfert marked an inline comment as done.
jdoerfert added inline comments.
================
Comment at: llvm/lib/Analysis/MemoryBuiltins.cpp:612
+ assert(!isa<GEPOperator>(CE) &&
+ "Constant GEPs should have been stripped already");
}
----------------
nikic wrote:
> Constant GEPs can have constant expression offsets, which will not be stripped.
Good point. I'll remove the assertion, nothing we can do with those otherwise.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118727/new/
https://reviews.llvm.org/D118727
More information about the llvm-commits
mailing list