[PATCH] D118632: [WIP][Clang]OpenMP] Add the codegen support for `atomic compare`

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6023
+  // llvm::OpenMPIRBuilder::InsertPointTy AllocaIP(
+  //     CGF.AllocaInsertPt->getParent(), CGF.AllocaInsertPt->getIterator());
+
----------------
leftover


================
Comment at: clang/test/OpenMP/atomic_ast_print.cpp:1
 // RUN: %clang_cc1 -verify -fopenmp -ast-print %s | FileCheck %s
 // RUN: %clang_cc1 -fopenmp -x c++ -std=c++11 -emit-pch -o %t %s
----------------
this is a parser/sema test, not codegen. Add to the other patch.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1360
   /// \param Loc          The insert and source location description.
-  /// \param AllocIP      Instruction to create AllocaInst before.
   /// \param X            The target atomic pointer to be updated.
----------------
move into the other patch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118632/new/

https://reviews.llvm.org/D118632