[PATCH] D112445: [fir] Add fir.array_access op

Wed Feb 2 13:06:28 PST 2022

clementval added a comment.

In D112445#3291757 <https://reviews.llvm.org/D112445#3291757>, @mehdi_amini wrote:

> In D112445#3275274 <https://reviews.llvm.org/D112445#3275274>, @clementval wrote:
>
>> So what do we do here? I think we are back to where we were before doing the array operations documentation. I would advocate for this to go through like this and when the full picture is available for everyone (not only people working on fir-dev) we could reopen the discussion and see if we find a better design.
>
> Right: it is worth finishing upstreaming fir-dev, with a TODO about revisiting the design and the underlying principles about this part of FIR.
> (I had removed any blocker on this revision earlier to signal that you could move forward from my point of view, sorry if I wasn't clear!)

Thanks Mehdi for commenting back on that. I'll had a proper TODO here before moving on.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112445/new/

https://reviews.llvm.org/D112445