[PATCH] D118724: [lld-macho] Add -pagezero_size

[Jared Irwin via Phabricator via llvm-commits]

Link1J added inline comments.


================
Comment at: lld/MachO/Target.h:136
 
   static constexpr uint64_t pageZeroSize = 1ull << 12;
   static constexpr size_t wordSize = 4;
----------------
int3 wrote:
> re the compilation bug above: what if you changed this from a `constexpr` to a `const`?
Changing `constexpr` to `const` doesn't work. But adding `inline` does work.
It seems the C++14 spec doesn't like doing what we want to do, because it fails on gcc with `-std=c++14`.
MSVC is the only one that doesn't care about the C++ version, and so it always works with MSVC and `clang-cl`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118724/new/

https://reviews.llvm.org/D118724