[PATCH] D118756: [ELF] Avoid wrapping unreferenced lazy symbols

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 2 10:43:20 PST 2022


smeenai added a comment.

In D118756#3290328 <https://reviews.llvm.org/D118756#3290328>, @peter.smith wrote:

> Implementation looks good to me. It may be worth writing a test involving LTO, for example a definition of lazy in a bitcode archive. As I understand the implementation this should work, but it may be worth having a regression test to catch it if it breaks.

Thanks for the suggestion. I added a test involving bitcode as well. (I didn't duplicate every single test scenario, because that felt like overkill, but the basic archive and `--start-lib` cases are covered.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118756/new/

https://reviews.llvm.org/D118756



More information about the llvm-commits mailing list