[PATCH] D112735: export unique symbol list with llvm-nm new option "--export-symbols"

[Digger Lin via Phabricator via llvm-commits]

DiggerLin added a comment.

In D112735#3289592 <https://reviews.llvm.org/D112735#3289592>, @jhenderson wrote:

> I've done a partial review of the latest update, but I'm currently quite exhausted and unable to focus enough to give you a further review.

Thanks a lot for your time and your professional review. I can update the patch based on the partial review.



================
Comment at: llvm/test/tools/llvm-nm/bitcode-export-sym.test:1
+## Test the option "--export-symbols" of llvm-nm for bitcode object file.
+
----------------
jhenderson wrote:
> I'm not sure if bitcode files are "object" files.
for the source code, llvm bitcode is IRObjectFile.


================
Comment at: llvm/tools/llvm-nm/Opts.td:20
 def dynamic : FF<"dynamic", "Display dynamic symbols instead of normal symbols">;
+def export_symbols : FF<"export-symbols", "Export symbol list for object files or archives">;
 def extern_only : FF<"extern-only", "Show only external symbols">;
----------------
jhenderson wrote:
> Could "for object files and archives" just be "for all inputs"?
there are MachOUniversalBinary and TapiUniversal, using "for all inputs" is more reasonable. thanks


================
Comment at: llvm/tools/llvm-nm/Opts.td:55
+
+def no_rsrc : FF<"no-rsrc", "Exclude the rsrc symbol from export symbol list"
+           "for xcoff (requires --export-symbols)">, Group<grp_xcoff_o>;
----------------
jhenderson wrote:
> 
it only exclude the "__rsrc" symbol from the export symbol list. 



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112735/new/

https://reviews.llvm.org/D112735