[PATCH] D118769: Split fast-basictest.ll according to passes responsible for optimizations

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In D118769#3290624 <https://reviews.llvm.org/D118769#3290624>, @kovdan01 wrote:

> In D118769#3290443 <https://reviews.llvm.org/D118769#3290443>, @spatel wrote:
>
>> For the files that still run multiple passes, I think we're trying to show that the combination of passes are cooperating to produce the expected/optimal result.
>> Can we move those to "llvm/test/Transforms/PhaseOrdering" and run "-O2" instead? That would show that we have the expected result from the typical optimization pipeline without needing to name specific passes. Then if something alters the pipeline and breaks the expected result, we'd know sooner.
>
> Thanks for this remark, moving such tests to llvm/test/Transforms/PhaseOrdering makes sense. Regarding using -O2 instead of naming specific passes - I suppose that both options have their benefits (we want to know if something breaks both in the whole pipeline and in a specific combination of passes), so I think that we can test both variants with `--check-prefix` opt's option. Such approach is already taken, for example, in X86/pr52078.ll. Please let me know if you approve such approach, and if yes - I'll do that.

Yes, we can use >1 RUN line for more coverage. There's little extra cost with that approach.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118769/new/

https://reviews.llvm.org/D118769