[PATCH] D116465: [SPIRV 6/6] Add 2 essential passes and the simplest tests

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

In D116465#3290716 <https://reviews.llvm.org/D116465#3290716>, @zuban32 wrote:

> @rengolin what would be considered as a proper implementation?

I don't think I have quite understood what the problem is, tbh.

If this is just some global value numbering, why is it being done so late (ie, not in IR)?

If this is a SPIR-V hardware requirement, that needs a specific guaranteed shape that cannot rely on the state of IR->MIR conversions (especially the generic parts), then there may not be another way out.

But I'll leave for others to express their opinions, as I'm not familiar with the problem.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116465/new/

https://reviews.llvm.org/D116465