[PATCH] D118229: [AMDGPUHSAMetadataStreamer] Do not assume ABI alignment for pointers
Yaxun Liu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 2 08:54:12 PST 2022
yaxunl added subscribers: b-sumner, Anastasia.
yaxunl added a comment.
In D118229#3290659 <https://reviews.llvm.org/D118229#3290659>, @arsenm wrote:
> In D118229#3290658 <https://reviews.llvm.org/D118229#3290658>, @kzhuravl wrote:
>
>> This change introduces the regression in OpenCL conformance test: basic - kernel_memory_alignment_local. Does it require any corresponding runtime changes?
>
> Is clang correctly emitting the align attribute on all these arguments?
clang does not do anything special for alignment of pointer type kernel arg. It assumes the pointee alignment is default 1. https://godbolt.org/z/xs195rKoW
Question is: What OpenCL spec says about kernel arg pointee alignment? @b-sumner @Anastasia
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118229/new/
https://reviews.llvm.org/D118229
More information about the llvm-commits
mailing list