[PATCH] D118769: Split fast-basictest.ll according to passes responsible for optimizations

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 2 07:41:30 PST 2022


spatel added a comment.

I didn't go over each test, but this seems good to me in providing better visibility about what each pass is responsible for.

For the files that still run multiple passes, I think we're trying to show that the combination of passes are cooperating to produce the expected/optimal result.
Can we move those to "llvm/test/Transforms/PhaseOrdering" and run "-O2" instead? That would show that we have the expected result from the typical optimization pipeline without needing to name specific passes. Then if something alters the pipeline and breaks the expected result, we'd know sooner.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118769/new/

https://reviews.llvm.org/D118769



More information about the llvm-commits mailing list