[PATCH] D118732: [BOLT] Add aarch64 support for peephole passes

Wed Feb 2 07:15:33 PST 2022

rafauler added inline comments.

================
Comment at: bolt/lib/Passes/BinaryPasses.cpp:110
+    "peepholes", cl::CommaSeparated, cl::desc("enable peephole optimizations"),
+    cl::value_desc("opt1,opt2,opt3,..."),
+    cl::values(clEnumValN(Peepholes::PEEP_NONE, "none", "disable peepholes"),
----------------
I'm not sure if this first character that phabricator is displaying here means there is a \t character in the source code. If there is, you should configure your editor to do not insert tabs and use only whitespaces (as per https://llvm.org/docs/CodingStandards.html#id18).

================
Comment at: bolt/lib/Passes/BinaryPasses.cpp:1093
 }
-
 void Peepholes::runOnFunctions(BinaryContext &BC) {
----------------
Removed this line by accident?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118732/new/

https://reviews.llvm.org/D118732