[PATCH] D76848: [CodeGen][ARM] Error when writing to specific reserved registers in inline asm

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D76848#1944305 <https://reviews.llvm.org/D76848#1944305>, @vhscampos wrote:

> It is diagnosing the same cases as the similar check present in CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp, lines 549-585. The latter, however, only covers clobber operands, leaving input and output operands unchecked.
>
> I created these diagnostics in SelectionDAGBuilder.cpp, rather than in AsmPrinterInlineAsm.cpp, because, in the latter, it's too late to catch the case where input operands are reserved registers (i.e. inline asm's "local register variables").

How is it too late? The reserved set of registers isn't known or frozen upfront, so this could miss cases


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76848/new/

https://reviews.llvm.org/D76848