[PATCH] D118715: [DebugInfo][InstrRef] Fix a tombstone-in-DenseMap crash from D117877
Jeremy Morse via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 2 06:39:08 PST 2022
jmorse added a comment.
In D118715#3289898 <https://reviews.llvm.org/D118715#3289898>, @StephenTozer wrote:
> Is there any particular reason that the undef value test couldn't exist within the original function, or are they separated to look cleaner? YMMV and I don't feel strongly either way, so LGTM.
I suppose if the `DBG_VALUE $noreg` was given for a different variable then that would work, I just didn't think of that. It would indeed be slightly simpler, but IMO not simpler enough to revise.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118715/new/
https://reviews.llvm.org/D118715
More information about the llvm-commits
mailing list