[PATCH] D118460: [DebugInfo][InstrRef] Use a depth-first search to reduce the lifetime of tracking information

Wed Feb 2 05:47:09 PST 2022

jmorse added a comment.

In D118460#3290118 <https://reviews.llvm.org/D118460#3290118>, @Orlando wrote:

> In D118460#3284107 <https://reviews.llvm.org/D118460#3284107>, @Orlando wrote:
>
>> Would it be worth caching `getBlocksForScope` results? If I'm reading this right it looks like it's called a few times with what should be the same inputs and outputs in a few places in the pass?
>
> wdyt about this? I'm happy for that to come as a separate patch if you agree, and it looks like @dblaikie's comments have been addressed, so LGTM if you make clang-format bot happy.

IMO that should happen, but not in this patch, simply out of being conservative -- this patch should be able to make its way into llvm14-rc1, and a follow-up patch caching getBlocksForScope should be able to get into rc2 (IMHO, YMMV).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118460/new/

https://reviews.llvm.org/D118460