[PATCH] D118773: [MachineLICM] Add shouldHoist method to TargetInstrInfo

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetInstrInfo.h:385
 
+  /// Return true if the instruction should be hoisted by MachineLICM.
+  ///
----------------
Since this hook only allows targets to //prevent// things from being hoisted, I wonder if "Return false if the instruction should not be hoisted by MachineLICM" would describe it better?

Similarly "override the default behavior" fails to mention that it can only be overridden in one direction.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118773/new/

https://reviews.llvm.org/D118773