[PATCH] D116492: [lld] Deprecate using llvm-config to detect llvm installation

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 2 03:47:57 PST 2022


nikic added inline comments.


================
Comment at: lld/CMakeLists.txt:14
+  set(LLVM_CONFIG_OUTPUT)
+  if(LLVM_CONFIG)
+    set (LLVM_CONFIG_FOUND 1)
----------------
Is it intentional that lld now requires you to set LLVM_CONFIG instead of LLVM_CONFIG_PATH? Based on the deprecation, I would have assumed that the previous name would be retained.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116492/new/

https://reviews.llvm.org/D116492



More information about the llvm-commits mailing list