[PATCH] D118577: [ELF] Deduplicate names of local symbols only with -O2

[ben via Phabricator via llvm-commits]

bd1976llvm added a comment.

In D118577#3288196 <https://reviews.llvm.org/D118577#3288196>, @MaskRay wrote:

> This .strtab deduplication makes parallel .symtab write difficult. I suspect we may need to disable it entirely in the future.

Thanks for making this optimization. I suspect disabling entirely is acceptable because the deduplication could be done via post-processing. There's going to be a trade off between the features offered and the amount of parallelism - I think that's fine as long as the speed up is reasonable. Users are evidently willing to go to great lengths to restructure their builds to get the most out of the build tools (game code often uses unity builds, for example).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118577/new/

https://reviews.llvm.org/D118577