[PATCH] D117887: [NVPTX] Expose float tys min, max, abs, neg as builtins

[Jakub Chlanda via Phabricator via llvm-commits]

jchlanda marked 2 inline comments as done.
jchlanda added inline comments.


================
Comment at: clang/test/CodeGen/builtins-nvptx.c:822
+  // CHECK_PTX70_SM80: call i16 @llvm.nvvm.fmin.bf16
+  __nvvm_fmin_bf16(0x1234, 0x7FBF);
+  // CHECK_PTX70_SM80: call i16 @llvm.nvvm.fmin.nan.bf16
----------------
tra wrote:
> I'd `#define` the magic values to give them sensible names.
I've added #defs for those values, they are not strictly needed (as in the values don't really matter) as this is not being executed, but I agree, it makes for a better read of the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117887/new/

https://reviews.llvm.org/D117887