[PATCH] D118672: [cmake][NFC] Configuration for libLLVM.so symbol versioning

Stephen Neuendorffer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 1 23:05:39 PST 2022


This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG76f37d41b751: [cmake][NFC] Configuration for libLLVM.so symbol versioning (authored by stephenneuendorffer).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118672/new/

https://reviews.llvm.org/D118672

Files:
  llvm/CMakeLists.txt
  llvm/tools/llvm-shlib/simple_version_script.map.in


Index: llvm/tools/llvm-shlib/simple_version_script.map.in
===================================================================
--- llvm/tools/llvm-shlib/simple_version_script.map.in
+++ llvm/tools/llvm-shlib/simple_version_script.map.in
@@ -1 +1 @@
-LLVM_ at LLVM_VERSION_MAJOR@ { global: *; };
+ at LLVM_SHLIB_SYMBOL_VERSION@ { global: *; };
Index: llvm/CMakeLists.txt
===================================================================
--- llvm/CMakeLists.txt
+++ llvm/CMakeLists.txt
@@ -28,6 +28,11 @@
     "${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}${LLVM_VERSION_SUFFIX}")
 endif()
 
+if(NOT DEFINED LLVM_SHLIB_SYMBOL_VERSION)
+  # "Symbol version prefix for libLLVM.so"
+  set(LLVM_SHLIB_SYMBOL_VERSION "LLVM_${LLVM_VERSION_MAJOR}")
+endif()
+
 if ((CMAKE_GENERATOR MATCHES "Visual Studio") AND (MSVC_TOOLSET_VERSION LESS 142) AND (CMAKE_GENERATOR_TOOLSET STREQUAL ""))
   message(WARNING "Visual Studio generators use the x86 host compiler by "
                   "default, even for 64-bit targets. This can result in linker "


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118672.405151.patch
Type: text/x-patch
Size: 1050 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220202/afba641b/attachment.bin>


More information about the llvm-commits mailing list