[PATCH] D116857: [libunwind] [sparc] Add SPARCv9 support

Arfrever Frehtes Taifersar Arahesis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 1 21:45:08 PST 2022


Arfrever added inline comments.


================
Comment at: libunwind/src/Registers.hpp:3642
+
+  uint64_t  getSP() const         { return _registers.__regs[UNW_SPARC_O6] + 2047; }
+  void      setSP(uint64_t value) { _registers.__regs[UNW_SPARC_O6] = value - 2047; }
----------------
Formatting of this `getSP()` method is not aligned with formatting of other methods in this class.


================
Comment at: libunwind/src/Registers.hpp:3663
+  memcpy(&_wcookie, static_cast<const uint8_t *>(registers) + sizeof(_registers),
+	 sizeof(_wcookie));
+}
----------------
This line should be `         sizeof(_wcookie));`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116857/new/

https://reviews.llvm.org/D116857



More information about the llvm-commits mailing list