[PATCH] D118441: Preserve aliasing info during memory intrinsics lowering

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D118441#3286321 <https://reviews.llvm.org/D118441#3286321>, @ebrevnov wrote:

> In D118441#3283987 <https://reviews.llvm.org/D118441#3283987>, @arsenm wrote:
>
>> Needs some lit tests that show the metadata after expansion
>
> The problem is there is now pass which runs this utility. I'm not aware how to exercise it from lit test. For that reason I had to create a unit test. Is there a way to build a lit test in such case?

AMDGPU uses this, see llvm/test/CodeGen/AMDGPU/lower-mem-intrinsics.ll



================
Comment at: llvm/lib/Transforms/Utils/LowerMemIntrinsics.cpp:80
                                                 PartSrcAlign, SrcIsVolatile);
+    if (!CanOverlap)
+      // Set alias scope for loads.
----------------
ebrevnov wrote:
> arsenm wrote:
> > Braces
> According to code style single statement if doesn't need braces.
It's spread over multiple lines with the comment, it should have braces


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118441/new/

https://reviews.llvm.org/D118441