[PATCH] D118144: [GVN] Support chain of phi nodes in exit blocks.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 1 13:47:32 PST 2022


fhahn planned changes to this revision.
fhahn added a comment.

In D118144#3285181 <https://reviews.llvm.org/D118144#3285181>, @reames wrote:

> Really not a fan here.
>
> I think what we need to do is recognize the address clobber being from a select, and then perform both sides of the memory dependency "as if" we had two loads at the point of the select.  Doing that would let this work generically.

That's a fair point, this patch is indeed very specific! Let me take a look at what some kind of 'fork-analysis' would take.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118144/new/

https://reviews.llvm.org/D118144



More information about the llvm-commits mailing list