[PATCH] D118143: [GVN] Support load of pointer-select to value-select conversion.

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 405089.
fhahn marked 5 inline comments as done.
fhahn added a comment.

In D118143#3285098 <https://reviews.llvm.org/D118143#3285098>, @reames wrote:

> This wasn't quite what I'd expected, but this approach appears to be workable, if not fully generic.

Thanks Philip, comments should be addressed. I intend to push the updated version with your comments addressed tomorrow, unless there are any concers raised.

> The fully generic result I was expecting was for you to generalize the available block mechanism into a mapping per address of availability per block plus a side structure to remember the address translation.  (We implicitly already have the later for phi nodes, but we'd have to track it explicitly for selects.)
>
> The general mechanism is a much deeper change, so I understand if you don't want to do it now.

I'd prefer to keep the scope limited to start with. When we move away from MemDepAnalysis here might be a good time to see if MemorySSA could help with generalizing this code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118143/new/

https://reviews.llvm.org/D118143

Files:
  llvm/lib/Transforms/Scalar/GVN.cpp
  llvm/test/Transforms/GVN/PRE/pre-load-through-select.ll
  llvm/test/Transforms/GVN/PRE/pre-loop-load-through-select.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118143.405089.patch
Type: text/x-patch
Size: 28224 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220201/99850b35/attachment.bin>