[PATCH] D114841: [lld-macho] Fix duplicate symbols with relocatable objects

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo added inline comments.


================
Comment at: lld/MachO/Driver.cpp:402
+    file_magic magic = identify_magic((*buffer).getBuffer());
+    switch (magic) {
+    case file_magic::macho_object:
----------------
int3 wrote:
> is this cleaner than caching all frameworks, regardless of file type? Or would we actually behave differently if this cached all files?
> 
> (just curious, not asking you to change it. But we should probably have a comment here about why we're only caching object and bitcode files)
Similar topic, is it better to check the cache first? (before even bothering to read the content of the file?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114841/new/

https://reviews.llvm.org/D114841