[PATCH] D118276: Adding a DIBuilder interface for Fortran's assumed length string

[Chih-Ping Chen via Phabricator via llvm-commits]

cchen15 added inline comments.


================
Comment at: llvm/include/llvm/IR/DIBuilder.h:237
     /// \param StrLocationExp   Optional memory location of the string.
-    DIStringType *createStringTypeExp(StringRef Name,
+    DIStringType *createStringType(StringRef Name,
                                       DIExpression *StringLengthExp,
----------------
One last suggestion: We can combine the two new functions into one by typing the length argument PointerUnion<DIVariable*, DIExpression*>.  Please see DIBuilder::createArrayType for a precedent.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118276/new/

https://reviews.llvm.org/D118276