[PATCH] D116821: [DebugInfo][InstrRef] Move instr-ref controlling flag out of TargetOptions

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

In D116821#3286031 <https://reviews.llvm.org/D116821#3286031>, @dblaikie wrote:

> Hmm - I'd at least be curious to know more about the criteria used. Those seem a bit more aggressive than I'd have figured - non-trivial inline functions in headers seem like they could be quite confusing to treat as nodebug.

Well, those are the criteria we landed on.  And of course it's controlled by a command-line option, so you can get everything if you want.

The argument (made by licensees; we didn't make this up out of thin air) is that in-class defined methods, and those explicitly marked as `inline` or `always_inline` in the source, do tend to be small and not the source of real bugs.  Also, making it obvious from the source whether a given function would be affected was a positive point.  Yes, a team could spend a lot of effort adding `nodebug` everywhere, but having the quick and easy ability to _get_ debug info for everything (by fiddling a command-line option, no tedious source modifications required) was also a win.

You can invent a counter example easily, but in our experience the counter-examples aren't the norm, at least for the licensees who asked for this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116821/new/

https://reviews.llvm.org/D116821