[PATCH] D118551: [ELF] De-template LinkerDriver::link. NFC

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 1 13:22:47 PST 2022


MaskRay added inline comments.


================
Comment at: lld/ELF/Target.h:302
+#ifdef __clang__
+#pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+#endif
----------------
lichray wrote:
> Should this be using push and pop?
Perhaps not worth the trouble. This usage is allowed in -std=c++20 mode...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118551/new/

https://reviews.llvm.org/D118551



More information about the llvm-commits mailing list