[PATCH] D118551: [ELF] De-template LinkerDriver::link. NFC

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D118551#3288308 <https://reviews.llvm.org/D118551#3288308>, @MaskRay wrote:

> In D118551#3288226 <https://reviews.llvm.org/D118551#3288226>, @mstorsjo wrote:
>
>> This causes a bunch of build warnings for me, like this:
>>
>>   ../tools/lld/ELF/InputSection.cpp:86:37: warning: ISO C++11 requires at least one argument for the "..." in a variadic macro  
>>      86 |     invokeELFT(parseCompressedHeader);
>>         |                                     ^
>
> What's your compiler? It may be the `-pedantic` option.
>
> This is supported since C++20 but we are compiling in -std=c++14 mode now.
>
> For older clang, I used `#pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"` to remove the diagnostic.

This is with GCC 9.3 (Ubuntu 20.04 default compiler).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118551/new/

https://reviews.llvm.org/D118551