[PATCH] D118692: [llvm-objcopy][COFF] Fix section name encoding

Nicolas Miller via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 1 10:49:54 PST 2022


npmiller updated this revision to Diff 405003.
npmiller added a comment.

This updated patch adds a test using `llvm-mc` to check the section name encoding, it is inspired from the MC test for this feature `llvm/test/MC/COFF/section-name-encoding.s`, but tweaked for `llvm-objcopy`.

It also fixes up the comment formatting, variable naming and zero-initialization as suggested.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118692/new/

https://reviews.llvm.org/D118692

Files:
  llvm/test/tools/llvm-objcopy/COFF/section-name-encoding.s
  llvm/tools/llvm-objcopy/COFF/Writer.cpp
  llvm/tools/llvm-objcopy/COFF/Writer.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118692.405003.patch
Type: text/x-patch
Size: 9462 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220201/94993439/attachment.bin>


More information about the llvm-commits mailing list