[PATCH] D118716: Change namespace llvm::swift to namespace llvm::swiftbinaryformat because of clashes with the apple/llvm-project repository

Shubham Sandeep Rastogi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 1 10:40:31 PST 2022


rastogishubham marked an inline comment as done.
rastogishubham added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/Swift.h:12
 namespace llvm {
-namespace swift {
+namespace swiftbinaryformat {
 
----------------
aprantl wrote:
> Since the enum starts with Swift, calling the namespace swift... is redundant.
> How about just calling the namespace "binaryformat"?
Sure let me change that


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118716/new/

https://reviews.llvm.org/D118716



More information about the llvm-commits mailing list