[PATCH] D118716: Change namespace llvm::swift to namespace llvm::swiftbinaryformat because of clashes with the apple/llvm-project repository

Shubham Sandeep Rastogi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 1 10:33:58 PST 2022


rastogishubham created this revision.
rastogishubham added a reviewer: aprantl.
Herald added a subscriber: hiraditya.
Herald added a reviewer: JDevlieghere.
rastogishubham requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The namespace llvm::swift is causing errors to pop up in the apple//llvm-project build when cherry-picking 4ce1f3d47c33 <https://reviews.llvm.org/rG4ce1f3d47c33daccfb7f4e906c3f57b404900036> into apple/llvm-project

/home/buildnode/jenkins/workspace/apple-llvm-project-pr-linux/swift/include/swift/Basic/FlaggedPointer.h:158:28: error: no template named 'FlaggedPointer' in namespace 'llvm::swift'; did you mean '::swift::FlaggedPointer'?
11:55:06     getAsVoidPointer(const swift::FlaggedPointer<PointerTy, BitPosition> &P) {
11:55:06                            ^~~~~~~~~~~~~~~~~~~~~
11:55:06                            ::swift::FlaggedPointer
11:55:06 /home/buildnode/jenkins/workspace/apple-llvm-project-pr-linux/swift/include/swift/Basic/FlaggedPointer.h:38:7: note: '::swift::FlaggedPointer' declared here
11:55:06 class FlaggedPointer {
11:55:06       ^


https://reviews.llvm.org/D118716

Files:
  llvm/include/llvm/BinaryFormat/Swift.h
  llvm/include/llvm/DWARFLinker/DWARFStreamer.h
  llvm/include/llvm/MC/MCObjectFileInfo.h
  llvm/include/llvm/Object/MachO.h
  llvm/include/llvm/Object/ObjectFile.h
  llvm/lib/DWARFLinker/DWARFStreamer.cpp
  llvm/lib/MC/MCObjectFileInfo.cpp
  llvm/lib/Object/MachOObjectFile.cpp
  llvm/tools/dsymutil/DwarfLinkerForBinary.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118716.404995.patch
Type: text/x-patch
Size: 6731 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220201/7c8f4c86/attachment.bin>


More information about the llvm-commits mailing list