[PATCH] D118713: [gn build] Remove -fmsc-version=1916

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks created this revision.
aeubanks added a reviewer: thakis.
aeubanks requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Now that the minimum version version of MSVC required to build LLVM has
been bumped, we see

  ../../llvm/include\llvm/Support/Compiler.h(94,2): error: LLVM requires
  at least VS 2019.
  #error LLVM requires at least VS 2019.

e.g. http://45.33.8.238/win/53703/step_4.txt

Using the detected version of MSVC seems fine.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D118713

Files:
  llvm/utils/gn/build/BUILD.gn


Index: llvm/utils/gn/build/BUILD.gn
===================================================================
--- llvm/utils/gn/build/BUILD.gn
+++ llvm/utils/gn/build/BUILD.gn
@@ -283,7 +283,6 @@
       "-Werror=date-time",
     ]
     if (current_os == "win") {
-      cflags += [ "-fmsc-version=1916" ]
       if (use_lld) {
         cflags += [ "/Brepro" ]
         ldflags += [ "/Brepro" ]


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118713.404970.patch
Type: text/x-patch
Size: 388 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220201/2d684951/attachment.bin>