[PATCH] D118560: [AArch64][SVE] NFC: tidy up isel lowering

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 1 08:42:42 PST 2022


sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

I agree with @david-arm that the commit message would benefit from some extra words. Otherwise, LGTM!



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1179-1182
+      setOperationAction(ISD::SADDSAT, VT, Legal);
+      setOperationAction(ISD::UADDSAT, VT, Legal);
+      setOperationAction(ISD::SSUBSAT, VT, Legal);
+      setOperationAction(ISD::USUBSAT, VT, Legal);
----------------
nit: I thought the default was Legal, so maybe these 4 lines can be removed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118560/new/

https://reviews.llvm.org/D118560



More information about the llvm-commits mailing list