[PATCH] D118614: [NFC] Remove isConstFalseVal in favour of using isNullOrNullSplat

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added a comment.

It would be nice if we could have a (scalable) vector test that uses SPLAT_VECTOR that exercises this function in some way.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:3228-3229
-
-  if (getBooleanContents(N->getValueType(0)) == UndefinedBooleanContent)
-    return !CN->getAPIntValue()[0];
-
----------------
It's clearly not guarded by any of the unit tests, but I think this case is now no longer supported? (i.e. if the value is `0b11111110`, it should still return `true` if `getBooleanContents` returns `UndefinedBooleanContent`).



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118614/new/

https://reviews.llvm.org/D118614