[PATCH] D118591: [Function Specialisation] Fix use after free

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In D118591#3287222 <https://reviews.llvm.org/D118591#3287222>, @SjoerdMeijer wrote:

> In D118591#3286952 <https://reviews.llvm.org/D118591#3286952>, @labrinea wrote:
>
>> I was wrong when I said we are not testing the removal of dead instructions. I was looking at the tests under the original commit D93838 <https://reviews.llvm.org/rGc4a0969b9c14acc795ae9e841b8289c3d36220b1>, but we have actually added more tests since. For example `function-specialization-constant-expression.ll` is exercising this code path.
>
> Ok, very good, that's what I thought.
>
> One more question about tests: does the sanitzer failure also happens/happened on these existing tests? If so, I think we are done. If not, we are possibly missing something and in this case, do we need to add a sanitizer test? I have never looked that, so don't even know if there are sanitizers tests that run opt.

To expose the issue, we might have to add a test where a compare that is used in a predicate gets simplified to a constant and removed and the solver needs to run again on the function.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118591/new/

https://reviews.llvm.org/D118591