[PATCH] D118696: Fix incorrect TypeSize->uint64_t cast in InductionDescriptor::isInductionPHI

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 1 05:48:02 PST 2022


sdesmalen added a comment.

The static_cast to int64_t was indeed incorrect and bailing out seems the right thing to do.

I think it's worth adding a test to `llvm/unittests/Analysis/IVDescriptorsTest.cpp` as well and testing the call to `isInductionPHI` explicitly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118696/new/

https://reviews.llvm.org/D118696



More information about the llvm-commits mailing list