[PATCH] D118560: [AArch64][SVE] NFC: tidy up isel lowering

Cullen Rhodes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 1 01:38:43 PST 2022


c-rhodes added a comment.

In D118560#3286664 <https://reviews.llvm.org/D118560#3286664>, @david-arm wrote:

> Hi @c-rhodes, could you add a description of why this refactoring is needed please? It's just not really obvious to me at least why we're shuffling code around.

Hi @david-arm, whilst adding legal types <-> register classes for Streaming SVE (D118561 <https://reviews.llvm.org/D118561>) I noticed that `hasSVE` predication block set operation actions for opcodes that may not be legal in Streaming SVE, and given there's another `hasSVE` further down that sets actions with loops over the same types I thought it made more sense to move them there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118560/new/

https://reviews.llvm.org/D118560



More information about the llvm-commits mailing list