[llvm] 783544b - [Attributor][FIX] Repair broken unit test

Johannes Doerfert via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 1 00:13:37 PST 2022


Author: Johannes Doerfert
Date: 2022-02-01T02:13:17-06:00
New Revision: 783544bd166d9b9185626cf17ff9a8f801407a96

URL: https://github.com/llvm/llvm-project/commit/783544bd166d9b9185626cf17ff9a8f801407a96
DIFF: https://github.com/llvm/llvm-project/commit/783544bd166d9b9185626cf17ff9a8f801407a96.diff

LOG: [Attributor][FIX] Repair broken unit test

Added: 
    

Modified: 
    llvm/unittests/Transforms/IPO/AttributorTest.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/unittests/Transforms/IPO/AttributorTest.cpp b/llvm/unittests/Transforms/IPO/AttributorTest.cpp
index ea4f1ba70f4c..d7c456c51473 100644
--- a/llvm/unittests/Transforms/IPO/AttributorTest.cpp
+++ b/llvm/unittests/Transforms/IPO/AttributorTest.cpp
@@ -202,7 +202,9 @@ TEST_F(AttributorTestBase, AAReachabilityTest) {
 
   // The second instruction of F9 can't reach the first call.
   ASSERT_FALSE(F9AA.instructionCanReach(A, F9SecondInst, F3, false));
-  ASSERT_FALSE(F9AA.instructionCanReach(A, F9SecondInst, F3, true));
+  // TODO: Without lifetime limiting callback this query does actually not make
+  //       much sense. "Anything" is reachable from the caller of func10.
+  ASSERT_TRUE(F9AA.instructionCanReach(A, F9SecondInst, F3, true));
 
   // The first instruction of F9 can reach the first call.
   ASSERT_TRUE(F9AA.instructionCanReach(A, F9FirstInst, F3));


        


More information about the llvm-commits mailing list