[PATCH] D118633: [Symbolizer] Add Build ID flag to llvm-symbolizer.

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: llvm/docs/CommandGuide/llvm-symbolizer.rst:189
+  Look up the object using the given build ID, specified as a hexadecimal
+  string. The --obj family of flags takes precedence.
+
----------------
I wonder whether it wouldn't be less error prone to diagnose the case when user uses both `--obj` and `--build-id` as an error? 


================
Comment at: llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp:264
 
+SmallVector<uint8_t> parseBuildID(StringRef BuildIDStr) {
+  std::string Bytes;
----------------
This is only invoked from one location so I'd consider inlining it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118633/new/

https://reviews.llvm.org/D118633