[PATCH] D116857: [libunwind] [sparc] Add SPARCv9 support

Mon Jan 31 20:39:53 PST 2022

koakuma added inline comments.

================
Comment at: libunwind/src/DwarfInstructions.hpp:87
+  case CFI_Parser<A>::kRegisterInCFADecrypt: // sparc64 specific
+    return addressSpace.getP(cfa + (pint_t)savedReg.value) ^
+           registers.getWCookie();
----------------
MaskRay wrote:
> Perhaps guard the getWCookie() usage with the sparc macro here so that other targets don't have to define `getWCookie`. The comment can then be moved here.
> 
> Then you may remove ` // sparc64 specific`.
>From my understanding, it wouldn't work when building with `-DLIBUNWIND_ENABLE_CROSS_UNWINDING=ON`.
In that case, the sparc64 target (which has `getWCookie`) and other targets (which doesn't have it) will be built together, and the build will fail because this line tries to call `getWCookie` on other targets' objects.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116857/new/

https://reviews.llvm.org/D116857