[PATCH] D105507: [AMDGPU] Add gfx10 assembler directive to specify shared VGPR count

[Jacob Lambert via Phabricator via llvm-commits]

lamb-j added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:4880
+    // SharedVGPRCount < 16 checked by PARSE_ENTRY_BITS
+    if (SharedVGPRCount && EnableWavefrontSize32)
+      return TokError("shared_vgpr_count directive not valid on "
----------------
arsenm wrote:
> Braces
Do we want braces here because the TokError() string is split over two lines?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105507/new/

https://reviews.llvm.org/D105507