[PATCH] D118647: [hwasan] work around lifetime issue with setjmp.
Evgenii Stepanov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 31 13:54:46 PST 2022
eugenis added inline comments.
================
Comment at: llvm/test/Instrumentation/HWAddressSanitizer/use-after-scope-setjmp.ll:26
+ store i8* %0, i8** @stackbuf, align 8
+ call void @may_jump() #7
+ call void @llvm.lifetime.end.p0i8(i64 4096, i8* nonnull %0) #10
----------------
eugenis wrote:
> so the callee of this may longjmp, bypassing the lifetime.end. Effectively, this adds a DT edge from any call site in this function to immediately after the setjmp call.
>
> Please add some comments here explaining this.
I meant to say "call graph edge".
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118647/new/
https://reviews.llvm.org/D118647
More information about the llvm-commits
mailing list